Reduce allocations in RpcWorkerConfigFactory.AddProviders #10959
Merged
Reduce allocations in RpcWorkerConfigFactory.AddProviders #10959
Conversation
surgupta-msft
approved these changes
Apr 15, 2025
liliankasem
approved these changes
Apr 15, 2025
fabiocav
reviewed
Apr 15, 2025
fabiocav
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #10931
RpcWorkerDescriptionobjects before filtering usingShouldAddWorkerConfig. Now, we skip loading configs for non-matching runtimes and only parse the config that matches FUNCTIONS_WORKER_RUNTIME, reducing unnecessary overhead after specialization.This change reduced allocations in the
AddProvidersmethod, during specialization (and even during placeholder mode).Before
After
Delta
RpcWorkerConfigFactory.AddProviders()- Total allocations dropped by 1,518 (30.13%).RpcWorkerConfigFactory.AddProviders()- Total allocated size reduced by ~238 KB (nearly 50%).Before
After
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
Additional PR information